You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hornebom
wants to merge
1
commit into
ing-bank:master
from
Hornebom:fix/switch--click-area--minimal-html
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While going through the repository, I noticed that the styling of the LionButton makes sure that the click area is always at least 44x44px. This neat detail is not in place for the LionSwitchButton. To make this particular css available for both components, I extracted it into a dedicated file and imported it into LionButton and LionSwitchButton.
Further I noticed that the LionSwitchButton contains more html elements than actually needed. The styles from the .btn and .switch-button__track can easily be used on :host. In that way there's less css to maintain and less html in the dom.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hornebom
requested review from
tlouisse,
daKmoR,
gerjanvangeest,
erikkroes,
ruphin,
narzac,
Knorgias,
whenlit and
DannyMoerkerke
as code owners
What I did
While going through the repository, I noticed that the styling of the
LionButtonmakes sure that the click area is always at least 44x44px. This neat detail is not in place for theLionSwitchButton. To make this particular css available for both components, I extracted it into a dedicated file and imported it intoLionButtonandLionSwitchButton.Further I noticed that the
LionSwitchButtoncontains more html elements than actually needed. The styles from the.btnand.switch-button__trackcan easily be used on:host. In that way there's less css to maintain and less html in the dom.